Built rough structure using Solid-nextjs template. #2

AOzmond · 2025-11-04T03:40:07Z

Rough structure of single page website, built using the Solid-nextjs template.

lietu · 2025-11-04T09:37:29Z

The dark mode selection does not automatically select dark mode based on my system settings, are you going to fix that in this PR or do you have another task somewhere tracking that?

lietu · 2025-11-04T09:38:58Z

this title should be larger or use e.g. this element instead

lietu · 2025-11-04T09:42:25Z

The entire codebases uses const foo = () => {} again instead of function foo() { ... }, fix

lietu · 2025-11-04T09:45:25Z

this part looks nothing like in the sketch

lietu · 2025-11-04T09:47:30Z

Font sizes and spacings are wrong.

lietu · 2025-11-04T09:48:24Z

Putting in actual dropdowns, buttons, and links shouldn't be too much work really

lietu · 2025-11-04T09:49:13Z

this is not broken up into the expected paragraphs

lietu · 2025-11-04T09:53:31Z

Make links look like links

lietu · 2025-11-04T10:07:01Z

You're not consistent about using <Link> vs <a>, any particular reason?

app/(site)/error/page.tsx

app/(site)/layout.tsx

package.json

README.md

- Updated package dependencies to their latest versions in `package.json`. - Switched the `lint` script to use `eslint .` instead of `next lint`.

…t files - Renamed `ErroPage` to `ErrorPage` for consistency. - Updated an anchor tag in Footer to include a valid href (`#`). - Removed unused `ToasterContext` import from layout file.

…nd redundant menu code.

…lean up CSS for improved consistency and reduced complexity.

…y and improve readability

…update styling; minor content improvements in Hero component.

…valid links, and simplify markup.

…st imports in layout and Features for consistency.

… `public/images/icon`.

…next-themes

…-to-Skill conversion in `skillsData`

…c versions

…ght`, and `skill` classes, and modify metadata for `USB Tree`.

…onent; minor styling updates in `Contact` and global CSS.

…next/next/no-img-element`.

…nd links in global CSS

…ops in layout

…` properties; improve accessibility for social media icons and enhance `ThemeToggler` with resolved theme detection.

…s, header structure adjustments, and `aria-label` addition; update feature data with descriptive `alt` text.

…me `FunFact` component to `Download`; update package metadata.

lietu

Pretty good progress, a few notes.

lietu · 2025-11-07T21:21:27Z

components/Footer/index.tsx

+                  <a
+                    rel="noopener"
+                    target="_blank"
+                    href="www.linkedin.com/in/alastair-ozmond-108512179"


lietu · 2025-11-07T21:22:50Z

app/(site)/error/page.tsx

+export default function ErrorPage() {
+  return (
+    <section className="overflow-hidden pt-45 pb-25 lg:pt-50 lg:pb-32.5 xl:pt-55 xl:pb-37.5">
+      <div className="mx-auto max-w-[518px] text-center">
+        <img src="/images/shape/404.svg" alt="404" className="mx-auto mb-7.5" />
+
+        <h2 className="mb-5 text-2xl font-semibold text-black md:text-4xl dark:text-white">
+          This Page Does Not Exist
+        </h2>
+        <p className="mb-7.5">
+          The page you were looking for appears to have been moved, deleted or
+          does not exist.
+        </p>
+
+        <Link
+          href="/"
+          className="hover:bg-blackho dark:bg-btndark dark:hover:bg-blackho inline-flex items-center gap-2.5 rounded-full bg-black px-6 py-3 font-medium text-white duration-300 ease-in-out"
+        >
+          Return to Home
+        </Link>
+      </div>
+    </section>
+  );
+}


This file appears unused, you seem to be missing some configuration somewhere?

btw https://docs.github.com/en/pages/getting-started-with-github-pages/creating-a-custom-404-page-for-your-github-pages-site

lietu · 2025-11-07T21:23:24Z

app/(site)/head.tsx

+export default function Head() {
+  return (
+    <>
+      <title> USB Tree - The USB device tree viewer and monitor.</title>


Suggested change

<title> USB Tree - The USB device tree viewer and monitor.</title>

<title>USB Tree - A cross-platform USB device tree viewer and monitor</title>

lietu · 2025-11-07T21:24:47Z

app/(site)/page.tsx

+import Contact from "@/components/Contact";
+
+export const metadata: Metadata = {
+  title: "USB Tree - The USB device tree viewer and monitor.",


Same update as in head

lietu · 2025-11-07T21:27:12Z

components/Contact/index.tsx

+          <div className="flex flex-col-reverse flex-wrap gap-8 md:flex-row md:flex-nowrap md:justify-between xl:gap-20">
+            <div className="shadow-solid-8 dark:border-strokedark w-full rounded-lg bg-white p-7.5 md:w-3/5 lg:w-3/4 xl:p-15 dark:border dark:bg-black">
+              <p className="text-body">
+                I'm Alastair, Software Engineer from Glasgow,Scotland, Currently


Suggested change

I'm Alastair, Software Engineer from Glasgow,Scotland, Currently

I'm Alastair, Software Engineer from Glasgow, Scotland, currently

lietu · 2025-11-07T21:38:13Z

components/Download/index.tsx

+                <a
+                  rel="noopener"
+                  target="_blank"
+                  href="https://github.com/AOzmond/usb-tree"


This is not the releases page.

lietu · 2025-11-07T21:38:57Z

components/Download/index.tsx

+                <p>Windows Package Manager</p>
+                <div className="rounded-lg bg-black/90 p-4 text-white">
+                  <code className="block font-mono">
+                    winget install usb-tree-app
+                  </code>
+                </div>


Suggested change

<p>Windows Package Manager</p>

<div className="rounded-lg bg-black/90 p-4 text-white">

<code className="block font-mono">

winget install usb-tree-app

</code>

</div>



While you don't yet have a winget package it's better not to claim that you do, but it's good that the placeholder has been tested.

lietu · 2025-11-07T21:43:28Z

public/images/features/multi-os.png

Can you make the background transparent?

lietu · 2025-11-07T21:45:34Z

README.md

+
+Project Website for usb-tree
+
+[Built using the Solid-Next.js template.](https://nextjstemplates.com/templates/solid)


Suggested change

[Built using the Solid-Next.js template.](https://nextjstemplates.com/templates/solid)

Built using the [Solid-Next.js template](https://nextjstemplates.com/templates/solid).

lietu · 2025-11-07T21:46:33Z

app/favicon.ico

What's the difference between these two files:

AOzmond added 2 commits November 3, 2025 19:24

Built rough structure using Solid-nextjs template.

b2d95bf

Update README.md to include Solid-Next.js template details

cbd8e08

AOzmond marked this pull request as ready for review November 4, 2025 03:41

Replace FunFact section with Download component in the main page layout

1b2a957

lietu suggested changes Nov 4, 2025

View reviewed changes

AOzmond added 16 commits November 4, 2025 02:43

ran prettier formatting and added link to readme.

73fc9f7

Update dependencies and improve ESLint configuration

8deacb9

- Updated package dependencies to their latest versions in `package.json`. - Switched the `lint` script to use `eslint .` instead of `next lint`.

Fix typo in ErrorPage component and minor updates in Footer and layou…

39e4af9

…t files - Renamed `ErroPage` to `ErrorPage` for consistency. - Updated an anchor tag in Footer to include a valid href (`#`). - Removed unused `ToasterContext` import from layout file.

Removed unused svgs and files.

63a10fc

Update shape dimensions in Hero component for consistency.

b6b5777

Remove ToasterContext and added spacing after "use client".

9685c3a

Simplify Header component by removing unused navigationOpen state a…

f77e0b1

…nd redundant menu code.

Replace Image components with img tags, remove unused SVGs, and c…

4959e5a

…lean up CSS for improved consistency and reduced complexity.

Refactor components to use named function declarations for consistenc…

1a2c740

…y and improve readability

Update Contact component styling and content

3260508

styled Download dropdown/button and view on github button

7d43d4b

Replace Link components with a tags in Header for simplicity and …

6c6efc7

…update styling; minor content improvements in Hero component.

Replace social media SVGs in Footer with img tags, update hrefs to …

2505a91

…valid links, and simplify markup.

Remove animate_top CSS class from components for cleaner code. Adju…

940d7e8

…st imports in layout and Features for consistency.

Add new social media SVG icons (Bluesky, dev.to, GitHub, LinkedIn) to…

c7df044

… `public/images/icon`.

Add suppressHydrationWarning to <html> for dark mode support via …

76b0818

…next-themes

AOzmond added 16 commits November 7, 2025 00:50

Update Feature icons with new images and add corresponding assets.

41e15a2

Update Feature icons with new images and add corresponding assets.

1cbd49c

Update SkillBox styling, expand skills list in YAML, and add string…

484e21c

…-to-Skill conversion in `skillsData`

Update dependencies and devDependencies in bun.lock file to specifi…

a53d2da

…c versions

Update styling for Contact and SkillBox, add text-body, `highli…

22758a8

…ght`, and `skill` classes, and modify metadata for `USB Tree`.

Add OS-specific download URLs with improved UI/UX for Download comp…

c0164fd

…onent; minor styling updates in `Contact` and global CSS.

update ESLint config to disable react/no-unescaped-entities and `@…

b058f73

…next/next/no-img-element`.

Update Footer and Header link styling; add hover effects for images a…

fe0e5e1

…nd links in global CSS

Add OS detection to Download component; simplify ThemeProvider pr…

8171178

…ops in layout

Refactor SectionHeader to remove unused subtitle and `description…

342cf45

…` properties; improve accessibility for social media icons and enhance `ThemeToggler` with resolved theme detection.

Enhance accessibility across components with improved alt attribute…

8465287

…s, header structure adjustments, and `aria-label` addition; update feature data with descriptive `alt` text.

Refactor Header component to use flex-row layout

7bd348e

Update metadata for Error Page to reflect USB Tree branding

b03d04b

Remove unused SVG icon from Error Page link button

6894dba

Update metadata to include detailed description for USB Tree

684fb9d

Remove unused icons, deprecated Menu type, and related assets; rena…

c01eaa1

…me `FunFact` component to `Download`; update package metadata.

lietu suggested changes Nov 7, 2025

View reviewed changes

	<title> USB Tree - The USB device tree viewer and monitor.</title>
	<title>USB Tree - A cross-platform USB device tree viewer and monitor</title>

	I'm Alastair, Software Engineer from Glasgow,Scotland, Currently
	I'm Alastair, Software Engineer from Glasgow, Scotland, currently


		Project Website for usb-tree

		[Built using the Solid-Next.js template.](https://nextjstemplates.com/templates/solid)

	[Built using the Solid-Next.js template.](https://nextjstemplates.com/templates/solid)
	Built using the [Solid-Next.js template](https://nextjstemplates.com/templates/solid).

Built rough structure using Solid-nextjs template. #2

Are you sure you want to change the base?

Built rough structure using Solid-nextjs template. #2

Uh oh!

Conversation

AOzmond commented Nov 4, 2025

Uh oh!

lietu commented Nov 4, 2025

Uh oh!

lietu commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lietu commented Nov 4, 2025

Uh oh!

lietu commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lietu commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lietu commented Nov 4, 2025

Uh oh!

lietu commented Nov 4, 2025

Uh oh!

lietu commented Nov 4, 2025

Uh oh!

lietu commented Nov 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lietu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lietu commented Nov 4, 2025 •

edited

Loading

lietu commented Nov 4, 2025 •

edited

Loading

lietu commented Nov 4, 2025 •

edited

Loading